Update AdvancedStylingTechniques on the docsite to recommend using getSlotClassNameProp_unstable #34266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behowell
requested review from
GeoffCoxMSFT,
ling1726,
micahgodbolt and
mltejera
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
sopranopillow
approved these changes
Apr 15, 2025
dmytrokirpa
approved these changes
Apr 16, 2025
behowell
commented
Apr 16, 2025
apps/public-docsite-v9/src/Concepts/AdvancedStylingTechniques.stories.mdx
Outdated
Show resolved
Hide resolved
mltejera
approved these changes
May 5, 2025
apps/public-docsite-v9/src/Concepts/AdvancedStylingTechniques.stories.mdx
Outdated
Show resolved
Hide resolved
terynk
reviewed
May 5, 2025
apps/public-docsite-v9/src/Concepts/AdvancedStylingTechniques.stories.mdx
Outdated
Show resolved
Hide resolved
dmytrokirpa
pushed a commit
to dmytrokirpa/fluentui
that referenced
this pull request
May 27, 2025
…tSlotClassNameProp_unstable (microsoft#34266)
mainframev
pushed a commit
to mainframev/fluentui
that referenced
this pull request
Jun 9, 2025
…tSlotClassNameProp_unstable (microsoft#34266)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This was originally in PR #34166 but was pulled out to have a separate discussion about documentation. For further context, please see this discussion thread: https://github.com/microsoft/fluentui/pull/34166/files#r2044847081
Previous Behavior
The documentation for custom style hooks on the public docsite does not mention using
getSlotClassNameProp_unstable, which is necessary for correctly implementing a custom style hook, to avoid overriding theclassNameset by a user.New Behavior
Update the AdvancedStylingTechniques article to demonstrate how to call
getSlotClassNameProp_unstablein a custom style hook.Related Issue(s)